x86: imply 'noapic' from 'nolapic'
authorKeir Fraser <keir.fraser@citrix.com>
Thu, 2 Apr 2009 12:02:13 +0000 (13:02 +0100)
committerKeir Fraser <keir.fraser@citrix.com>
Thu, 2 Apr 2009 12:02:13 +0000 (13:02 +0100)
While in the comments to an earlier submitted (and already applied)
patch I claimed to have fixed the need to specify both "nolapic" and
"noapic" when "nolapic" alone should already have the intended effect,
this doesn't appear to be the case. Here are the missing bits.

Signed-off-by: Jan Beulich <jbeulich@novell.com>
xen/arch/x86/apic.c

index 2bbb003eaa4c263d484bade0fd986d7575359622..aab68048eb7b4da23c56ca5739d7c1ba4adf7d6a 100644 (file)
@@ -1303,8 +1303,10 @@ int __init APIC_init_uniprocessor (void)
     if (enable_local_apic < 0)
         clear_bit(X86_FEATURE_APIC, boot_cpu_data.x86_capability);
 
-    if (!smp_found_config && !cpu_has_apic)
+    if (!smp_found_config && !cpu_has_apic) {
+        skip_ioapic_setup = 1;
         return -1;
+    }
 
     /*
      * Complain if the BIOS pretends there is one.
@@ -1313,6 +1315,7 @@ int __init APIC_init_uniprocessor (void)
         printk(KERN_ERR "BIOS bug, local APIC #%d not detected!...\n",
                boot_cpu_physical_apicid);
         clear_bit(X86_FEATURE_APIC, boot_cpu_data.x86_capability);
+        skip_ioapic_setup = 1;
         return -1;
     }